Fix potential buffer overflow by resizing buffer #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…buffer Increased the size of the buf array in generate_field from 32 to 33 bytes to ensure it can safely accommodate the largest possible string generated by sprintf. The new size accounts for a worst-case scenario where the formatted string includes three maximum-sized 32-bit integers, two delimiters (- and /), and a null terminator. This change resolves a compiler warning about potential overflows (-Werror=format-overflow).
|
@gmircea Theoretical worst case would be 36 if there is a negative integer. Practically 3rd argument can never be high as it is bounded by max, so even 32 seems to waste space. I think 9 should be enough if We discount years, and 13 if We count years. So I am inclined to cut it into 16. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increased the size of the buf array in generate_field from 32 to 33 bytes to ensure it can safely accommodate the largest possible string generated by sprintf.
The new size accounts for a worst-case scenario where the formatted string includes three maximum-sized 32-bit integers, two delimiters (- and /), and a null terminator.
This change resolves a compiler warning (uClibc) about potential overflows (-Werror=format-overflow).