Skip to content

[Tech; Proposal] Update "Select all"/"unselect all" control #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: tech/folder-names
Choose a base branch
from
Open

[Tech; Proposal] Update "Select all"/"unselect all" control #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions ...ps/etoolbox-rollout-manager/clientlibs/rollout-manager-ui/css/console-ui.checkboxlist.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,12 @@
padding: 0;
}

.rollout-manager-select-all {
font-size: small;
min-width: 86px;
.rollout-manager-select-all .coral3-Checkbox-description {
color: #666;
font-size: 0.75rem;
padding-top: 0.15rem;
text-decoration: underline;
text-decoration-style: dashed;
}

.rollout-manager-coral-accordion-item-content {
Expand All @@ -56,8 +59,8 @@
}

.rollout-manager-dialog .coral3-Dialog-wrapper {
width: 800px;
height: 566px;
width: 800px;
}

.rollout-manager-dialog .coral3-Checkbox {
Expand Down Expand Up @@ -85,7 +88,7 @@

.rollout-manager-nestedcheckboxlist-container {
overflow-y: auto;
height: 206px;
height: 246px;
}

.rollout-manager-logger-dialog .coral3-Dialog-wrapper {
Expand Down
43 changes: 27 additions & 16 deletions ..._root/apps/etoolbox-rollout-manager/clientlibs/rollout-manager-ui/js/console-ui.dialog.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,9 +137,7 @@
.text(TARGET_PATHS_LABEL);
label.appendTo(span);

const selectAll = $('<a is="coral-anchorbutton" variant="quiet" class="rollout-manager-select-all">')
.text(SELECT_ALL_LABEL);
selectAll.appendTo(span);
$(`<coral-checkbox class="rollout-manager-select-all">${SELECT_ALL_LABEL}</coral-checkbox>`).appendTo(span);

span.appendTo(sourceElement);
}
Expand Down Expand Up @@ -217,31 +215,44 @@
};
}

function changeSelectAllLabel(hasSelection) {
const selectAllEl = $('.rollout-manager-select-all');
selectAllEl.text(hasSelection ? UNSELECT_ALL_LABEL : SELECT_ALL_LABEL);
}

function hasSelection() {
return $(CORAL_CHECKBOX_ITEM + '[checked]').length > 0;
}

function selectUnselectAll() {
$(CORAL_CHECKBOX_ITEM).filter(':not([disabled])').prop('checked', !hasSelection());
function isFullySelected() {
return $(CORAL_CHECKBOX_ITEM).filter(':not([disabled])').length === $(CORAL_CHECKBOX_ITEM + '[checked]').length;
}

function selectUnselectAll(checked) {
$(CORAL_CHECKBOX_ITEM).filter(':not([disabled])').prop('checked', checked);
}

function validateSelection(hasSelection, submitBtn) {
function changeButtonState(hasSelection, submitBtn) {
submitBtn.attr('disabled', !hasSelection);
}

function onCheckboxChange(submitBtn) {
const hasAnySelection = hasSelection();
changeSelectAllLabel(hasAnySelection);
validateSelection(hasAnySelection, submitBtn);
const $selectAll = $('.rollout-manager-select-all');
const $selectAllLabel = $selectAll.find('label');
if (hasSelection()) {
if (isFullySelected()) {
$selectAll.prop('checked', true).prop('indeterminate', false);
} else {
$selectAll.prop('checked', true).prop('indeterminate', true);
}
$selectAllLabel.text(UNSELECT_ALL_LABEL);
changeButtonState(true, submitBtn);
} else {
$selectAll.prop('checked', false).prop('indeterminate', false);
$selectAllLabel.text(SELECT_ALL_LABEL);
changeButtonState(false, submitBtn);
}
}

function onSelectAllClick(submitBtn) {
selectUnselectAll();
const $selectAll = $('.rollout-manager-select-all');
const allSelected = !!$selectAll.prop('checked');
selectUnselectAll(!allSelected);
onCheckboxChange(submitBtn);
}

Expand Down Expand Up @@ -312,7 +323,7 @@

dialog.show();

validateSelection(hasSelection(), $submitBtn.add($rolloutBtn));
changeButtonState(hasSelection(), $submitBtn.add($rolloutBtn));

return deferred.promise();
}
Expand Down