Skip to content

Conversation

@AlKaliada
Copy link
Contributor

No description provided.

@github-actions
Copy link

CLA Assistant Lite bot: Thank you for your submission, we really appreciate it. We ask that you sign our Contributor Licence Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


akaliada seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request

Copy link
Collaborator

@smiakchilo smiakchilo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally very nice, thank you 👍 .
Please name either the pull-request and the commits according to the requirements:
[EAK-365] Bla-bla
https://github.com/exadel-inc/etoolbox-authoring-kit/blob/master/CONTRIBUTING.md#procedural-pull-request-questions
Please test/make sure that the new component works
a) in multifields
b) with DependsOn actions, such as "visible", "disabled", and especially "set" and "set-if-blank"

@smiakchilo smiakchilo changed the title Feature/eak 366 autocomplete [EAK-366] Implemented Autocomplete component Sep 1, 2022
@AlKaliada
Copy link
Contributor Author

Generally very nice, thank you 👍 . Please name either the pull-request and the commits according to the requirements: [EAK-365] Bla-bla https://github.com/exadel-inc/etoolbox-authoring-kit/blob/master/CONTRIBUTING.md#procedural-pull-request-questions Please test/make sure that the new component works a) in multifields b) with DependsOn actions, such as "visible", "disabled", and especially "set" and "set-if-blank"

Tested in multifields, with DependsOn actions, such as "visible", "disabled", and especially "set" and "set-if-blank"

* See the License for the specific language governing permissions and
* limitations under the License.
*/
package com.exadel.aem.toolkit.api.annotations.widgets.autocomplete3;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
package com.exadel.aem.toolkit.api.annotations.widgets.autocomplete3;
package com.exadel.aem.toolkit.api.annotations.widgets.?.autocomplete;

@smiakchilo smiakchilo added the AEM AEM-specific competencies are involved label Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AEM AEM-specific competencies are involved

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants