[EDMTP-281] DependsOn: add fill-select option #282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
nattallius
force-pushed
the
feature/EDMTP-281
branch
from
ce939c3 to
16245f5
Compare
nattallius
requested review from
ala-n and
smiakchilo
and removed request for
ala-n and
smiakchilo
|
I have read the CLA Document and I hereby sign the CLA |
smiakchilo
approved these changes
Feb 10, 2022
| /** | ||
| * Refreshes the options set of a Coral3 Select widget with provided values | ||
| */ | ||
| public static final String FILL_SELECT = "fill-select"; |
There was a problem hiding this comment.
A question is:
Are we always going to fill only selects? No raidoGroups/ buttonGroups / autocompletes? May it be, we would want to give a more generic name, kind of "fill-options"?
| * @param {string} option.value - actual value of an option | ||
| * @param selectedValue - value or array of values to trigger 'selected' state of the option | ||
| */ | ||
| static createOption(option, selectedValue) { |
There was a problem hiding this comment.
update-datasource action is creating Select options as well. May I kindly ask you to look into that action and possibly implement these methods there? So that we have a more unified codebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.