Skip to content

Add files via upload #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

PhilippSPOTTERON
Copy link

Logo Upgrades

@eworkers
Copy link
Owner

eworkers commented Dec 1, 2022

Thank you for your efforts @PhilippSPOTTERON !
Let us point a few things.
As we stated before, this fork is only an intermediate one between J4 compatibility and the official K2 version.
Theoretically it should lose its purpose when K2 official version supporting J4 sees the light.
This is still K2, and does not only support J4, but also J3.9+.
Labeling the J4 support somehow can be a good idea, minor displacement of K2 text and the icon part of the logo can also be another.
But changing the K2 logo itself is not! because this is still K2, beside if it wasn't, if the name still K2 regardless of the fact that the component was changed, K2 summit has not been changed :) (we can change the component but we cannot change the summit, it won't K2 then and won't be majestic and the hardest to climb)

We think small adjustment to just label the version differently for users should be enough (ex: what you did with the label k2 for j4, except it should be maybe k2 for J3.9+)

If you have different opinion, please share it in here.
And again thank you for efforts, it is much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants