feat: support env configs as option in bpftime cli tool #378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Officeyutong can you please help with passing the failing actions. |
Officeyutong
requested changes
Apr 21, 2025
|
|
||
| static std::pair<std::string, std::vector<std::string> > | ||
| static std::tuple<std::string, std::vector<std::string>, std::vector<const char *>> | ||
| extract_path_and_args(const argparse::ArgumentParser &parser) |
There was a problem hiding this comment.
The function name might need to be changed
| log_path_string += log_path; | ||
| env_args.push_back(log_path_string.c_str()); | ||
| } | ||
| if (parser.get<bool>("--allow-enternal-maps")) { |
| const char *disable_jit_str = "BPFTIME_DISABLE_JIT=true"; | ||
| env_args.push_back(disable_jit_str); | ||
| } | ||
| if (parser.get<bool>("--run-wit-kernel")) { |
| try { | ||
| items = parser.get<std::vector<std::string> >("COMMAND"); | ||
|
|
||
| if (parser.is_subcommand_used("load") || parser.is_subcommand_used("start")) { |
There was a problem hiding this comment.
extract_path_and_args is receiving a sub parser, not the full parser. So there is no sub commands under it, and these parser.is_subcommand_used calls will always throw exception
Reviewed |
|
Thanks @Officeyutong, will resolve them. |
yunwei37
force-pushed
the
master
branch
2 times, most recently
from
cbcb1e9 to
20acd88
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #331
Type of change
How Has This Been Tested?
Test Configuration:
Checklist