Ssh exec 2 #6
Open
Ssh exec 2 #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow `git_str_puts_escaped` to take an escaping prefix and an escaping suffix; this allows for more options, including the ability to better support escaping executed paths.
When sending paths to the remote server, escape them properly. Escape them with a single quote, followed by the escaped character, followed by another single quote. This prevents misparsing on the remote side and potential command injection.
Ensure that our `find_executable` behaves as expected: * When the executable contains a fully- or partially-qualified filename component (eg, `foo/bar`) that `PATH` is not searched; these paths are relative to the current working directory. * An empty segment in `PATH` (on POSIX systems) is treated as the current directory; this is for compatibility with Bourne shells. * When a file exists in `PATH`, it is actually executable (on POSIX)
* Do not search `PATH` for fully- or partially-qualified filenames (eg, `foo/bar`) * Ensure that a file in the `PATH` is executable before returning it
Ensure that when we look for an executable on Windows that we add executable suffixes (`.exe`, `.cmd`). Without this, we would not support looking for (eg) `ssh`, since we actually need to identify a file named `ssh.exe` (or `ssh.cmd`) in `PATH`.
Construct the arguments for the ssh exec as an explicit array, instead of trying to create a command-line for sh. The latter may use user input (the remote path) so this may be vulnerable to command injection.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.