test(kademlia): Add synctest to TestAddressBookQuickPrune and remove … #5274
+40
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akrem-chabchoub
force-pushed
the
migrate-to-synctest-kademlia-flaky
branch
from
634753a to
119231f
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors a flaky test by leveraging Go's testing/synctest package to provide deterministic execution for time-dependent test logic, removing the "_FLAKY" suffix from the test name.
- Wraps
TestAddressBookQuickPrune(previouslyTestAddressBookQuickPrune_FLAKY) withsynctest.Testfor deterministic time handling - Removes
t.Parallel()call (incompatible withsynctest.Test) - Adds
testing/synctestimport to support the new testing approach
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| testutil.CleanupCloser(t, kad) | ||
|
|
||
| time.Sleep(100 * time.Millisecond) | ||
| time.Sleep(100 * time.Millisecond) |
There was a problem hiding this comment.
When using synctest.Test, real time.Sleep calls should typically be avoided as they defeat the purpose of deterministic time simulation. Consider removing this sleep or verifying if it's necessary with synctest's time control mechanisms.
Suggested change
| time.Sleep(100 * time.Millisecond) | |
| synctest.Advance(t, 100 * time.Millisecond) |
Contributor
Author
There was a problem hiding this comment.
There is no synctest.Advance in the docs 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Open API Spec Version Changes (if applicable)
Motivation and Context (Optional)
Related Issue (Optional)
Screenshots (if appropriate):