Skip to content

Conversation

@seongyun-ko
Copy link
Contributor

@seongyun-ko seongyun-ko commented Oct 27, 2025

Note

Introduce a dedicated EL consolidation role and gate requestConsolidation by it, with fork tests validating EOA access and revert behavior.

  • Contracts:
    • Add new role constant ETHERFI_NODES_MANAGER_EL_CONSOLIDATION_ROLE in src/EtherFiNodesManager.sol.
    • Update requestConsolidation(...) to remove onlyAdmin and explicitly require roleRegistry.hasRole(ETHERFI_NODES_MANAGER_EL_CONSOLIDATION_ROLE, msg.sender); retain fee and input validations and forwarding to IEtherFiNode.
  • Tests:
    • Add fork test test/pectra-fork-tests/Consolidation-through-EOA.sol:
      • Verifies an EOA with ETHERFI_NODES_MANAGER_EL_CONSOLIDATION_ROLE can call requestConsolidation and emits expected event.
      • Verifies calls revert for EOAs without the role.
      • Includes setup to upgrade EFNM and link legacy validator IDs.

Written by Cursor Bugbot for commit 92d8324. This will update automatically on new commits. Configure here.

@seongyun-ko seongyun-ko changed the title allow an EoA to call EFNM.requestConsolidation Add a role ETHERFI_NODES_MANAGER_EL_CONSOLIDATION_ROLE to allow it to call EFNM.requestConsolidation Oct 27, 2025
@sherlock-ai-beta
Copy link

Sherlock AI Findings

The automated tool completed its analysis of the codebase and found no potential security issues.

Next Steps: No immediate actions are required. Continue monitoring the codebase with future scans.

Full report available at: https://ai.sherlock.xyz/runs/dc012a99-b938-4a90-a128-7f596b21fc5a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants