Skip to content

ethclient/gethclient: fix flaky testcase for TestSubscribePendingTxHashes #33054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

ethclient/gethclient: fix flaky testcase for TestSubscribePendingTxHashes #33054

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b06a09
ethclient/gethclient: fix flaky testcase for TestSubscribePendingTxHa…
hero5512 Oct 29, 2025
0ecf792
add timeout for channel receiving
hero5512 Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 30 additions & 9 deletions ethclient/gethclient/gethclient_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ import (
"math/big"
"strings"
"testing"
"time"

"github.com/ethereum/go-ethereum"
"github.com/ethereum/go-ethereum/common"
Expand Down Expand Up @@ -413,12 +414,20 @@ func testSubscribePendingTransactions(t *testing.T, client *rpc.Client) {

// Subscribe to Transactions
ch1 := make(chan common.Hash)
ec.SubscribePendingTransactions(context.Background(), ch1)
sub1, err := ec.SubscribePendingTransactions(context.Background(), ch1)
if err != nil {
t.Fatalf("Failed to subscribe to pending transactions: %v", err)
}
defer sub1.Unsubscribe()

// Subscribe to Transactions
ch2 := make(chan *types.Transaction)
ec.SubscribeFullPendingTransactions(context.Background(), ch2)

sub2, err := ec.SubscribeFullPendingTransactions(context.Background(), ch2)
if err != nil {
t.Fatalf("Failed to subscribe to full pending transactions: %v", err)
}
defer sub2.Unsubscribe()
time.Sleep(100 * time.Millisecond)
// Send a transaction
chainID, err := ethcl.ChainID(context.Background())
if err != nil {
Expand All @@ -445,14 +454,26 @@ func testSubscribePendingTransactions(t *testing.T, client *rpc.Client) {
t.Fatal(err)
}
// Check that the transaction was sent over the channel
hash := <-ch1
if hash != signedTx.Hash() {
t.Fatalf("Invalid tx hash received, got %v, want %v", hash, signedTx.Hash())
select {
case hash := <-ch1:
if hash != signedTx.Hash() {
t.Fatalf("Invalid tx hash received, got %v, want %v", hash, signedTx.Hash())
}
case err := <-sub1.Err():
t.Fatalf("Subscription error: %v", err)
case <-time.After(5 * time.Second):
t.Fatal("Timeout waiting for pending transaction hash")
}
// Check that the transaction was sent over the channel
tx = <-ch2
if tx.Hash() != signedTx.Hash() {
t.Fatalf("Invalid tx hash received, got %v, want %v", tx.Hash(), signedTx.Hash())
select {
case tx = <-ch2:
if tx.Hash() != signedTx.Hash() {
t.Fatalf("Invalid tx hash received, got %v, want %v", tx.Hash(), signedTx.Hash())
}
case err := <-sub2.Err():
t.Fatalf("Subscription error: %v", err)
case <-time.After(5 * time.Second):
t.Fatal("Timeout waiting for full pending transaction")
}
}

Expand Down
Loading