Skip to content

cmd/devp2p/internal/ethtest: cover acceptable differences in communication #33031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

cmd/devp2p/internal/ethtest: cover acceptable differences in communication #33031

wants to merge 1 commit into from
+11 −4

Conversation

@flcl42
Copy link
Contributor

@flcl42 flcl42 commented Oct 27, 2025 •
edited
Loading

  • Fix disconnection detection
  • Add 1gwei tip
  • Handle two pooled tx requests

flcl42
flcl42 commented Oct 27, 2025
View reviewed changes
cmd/devp2p/internal/ethtest/suite.go

// Check if peer disconnects at the end.
code, _, err := conn.Read()
if err == errDisc || code == discMsg {
Copy link
Contributor Author

@flcl42 flcl42 Oct 27, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fjl It seems like the test fails when we do disconnect, or I'm missing something obvious

@flcl42 flcl42 marked this pull request as ready for review October 30, 2025 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@flcl42