all: generate and embed block-access-lists in block bodies when --experimentalbal is enabled
#32586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwasinger
force-pushed
the
bal-generation
branch
from
7a96aa6 to
c98f0aa
Compare
jwasinger
requested review from
fjl,
gballet,
rjl493456442,
zsfelfoldi,
MariusVanDerWijden,
s1na and
lightclient
as code owners
| // Block Access List flags | ||
|
|
||
| ExperimentalBALFlag = &cli.BoolFlag{ | ||
| Name: "experimentalbal", |
There was a problem hiding this comment.
--experimental.bal ?
| // a block. It is an amalgamation of state access/modification functionality | ||
| // utilized by EVM execution and other functionality needed in block execution | ||
| // (e.g. state root calculation). | ||
| type BlockProcessingDB interface { |
There was a problem hiding this comment.
Most of the methods here are the same as vm.StateDB, can we somehow combine these interfaces? So that we don't need to change 2 places if anything changes.
There was a problem hiding this comment.
Yes, but we will have to move the interface up to the core package.
Originally, I tried to define BlockProcessingDB as being composed of vm.StateDB. However, that creates a cyclical import between core/vm and core/state.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pulls a few changes out from the larger BAL branch #32263:
StateDBis modified to return the modified state as well as accessed state fromFinaliseif it has been explicitly enabled withStateDB.EnableStateDiffRecording.StateDBfunctionality required for fully executing blocks is introduced instate.BlockProcessingDB(tentative name). Block state processor/validator, consensus engines have been modified to take aBlockProcessingDBin place ofStateDB.AccessListCreationDB(tentative name) is introduced which implementsBlockProcessingDB. It wraps access to an innerBlockProcessingDBinstance and is responsible for intercepting state reads/mutations returned fromFinaliseand using these to construct a block access list.StateDBitself in order to construct BALs, and keep the concept of block-access-lists opaque to theStateDB.--experimentalbalis specified. The use-case for this is that I self-validate the BAL-generation and verification in the other larger BAL branch by executing the entire blockchain test spec.TODOs