dev: simplify condition in is_account_alive #1190
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enitrat
force-pushed
the
dev/simplify-is-account-alive
branch
from
ac5904d to
85f5945
Compare
|
hi @SamWilsn, @gurukamath, I made a small change for clarity, let me know how that sounds! |
SamWilsn
reviewed
Apr 28, 2025
src/ethereum/arrow_glacier/state.py
Outdated
| @@ -463,11 +463,7 @@ def is_account_alive(state: State, address: Address) -> bool: | |||
| if account is None: | |||
There was a problem hiding this comment.
Or even:
return account is not None and account != EMPTY_ACCOUNTThere was a problem hiding this comment.
yeah definitely better this way :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
The condition for
is_account_aliveis strictly equivalent to== EMPTY_ACCOUNT. Thus, for simplicity, I modified it (and ensuring that if the Account model came to change, this would be properly reflected in this function.