Skip to content

Conversation

marioevz
Copy link
Member

@marioevz marioevz commented Sep 9, 2025

🗒️ Description

Allows exception in tests in tests/osaka/eip7594_peerdas/test_max_blob_per_tx.py to be either TransactionException.TYPE_3_TX_MAX_BLOB_GAS_ALLOWANCE_EXCEEDED or TransactionException.TYPE_3_TX_BLOB_COUNT_EXCEEDED, reasoning being that the client can do either of the checks in any order, which seems to be the case for Reth.

test_max_blobs_per_tx_fork_transition is also modified to have a pre-fork block that is always valid, and have the invalid block always be at the fork boundary.

🔗 Related Issues or PRs

N/A.

✅ Checklist

  • All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    uvx --with=tox-uv tox -e lint,typecheck,spellcheck,markdownlint
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered adding an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).

@marioevz marioevz requested a review from spencer-tb September 9, 2025 21:21
@marioevz marioevz added scope:tests Scope: Changes EL client test cases in `./tests` fork:osaka Osaka hardfork labels Sep 9, 2025
@spencer-tb
Copy link
Contributor

I think I made it specific so all clients would return a different error for when blobs > 9 vs between 6 and 9.
Clients should reject at block level validation when > 9 and tx level validation other wise.

I'm concerned if we do this that we could miss the block level validation error like this one here: https://hive.ethpandaops.io/#/test/fusaka/1757424480-ac958c413f4b97eac6c2116aedbadcb6?testnumber=1483

Digging more just now.

@spencer-tb
Copy link
Contributor

Closing as issue resolved.

@spencer-tb spencer-tb closed this Sep 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fork:osaka Osaka hardfork scope:tests Scope: Changes EL client test cases in `./tests`
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants