fix(tests): Relax exception expected in test_max_blob_per_tx.py #2122
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
Allows exception in tests in
tests/osaka/eip7594_peerdas/test_max_blob_per_tx.py
to be eitherTransactionException.TYPE_3_TX_MAX_BLOB_GAS_ALLOWANCE_EXCEEDED
orTransactionException.TYPE_3_TX_BLOB_COUNT_EXCEEDED
, reasoning being that the client can do either of the checks in any order, which seems to be the case for Reth.test_max_blobs_per_tx_fork_transition
is also modified to have a pre-fork block that is always valid, and have the invalid block always be at the fork boundary.🔗 Related Issues or PRs
N/A.
✅ Checklist
tox
checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx --with=tox-uv tox -e lint,typecheck,spellcheck,markdownlint
type(scope):
.