-
Notifications
You must be signed in to change notification settings - Fork 171
refactor(tests): add checklist marker for eip7825 #2107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
tests/osaka/eip7825_transaction_gas_limit_cap/test_tx_gas_limit.py
Outdated
Show resolved
Hide resolved
tests/osaka/eip7825_transaction_gas_limit_cap/test_tx_gas_limit_transition_fork.py
Outdated
Show resolved
Hide resolved
68944a6
to
5b1ae11
Compare
tests/osaka/eip7825_transaction_gas_limit_cap/test_tx_gas_limit_transition_fork.py
Outdated
Show resolved
Hide resolved
tests/osaka/eip7825_transaction_gas_limit_cap/test_tx_gas_limit_transition_fork.py
Outdated
Show resolved
Hide resolved
tests/osaka/eip7825_transaction_gas_limit_cap/test_tx_gas_limit_transition_fork.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tests/osaka/eip7825_transaction_gas_limit_cap/test_tx_gas_limit.py
Outdated
Show resolved
Hide resolved
tests/osaka/eip7825_transaction_gas_limit_cap/test_tx_gas_limit.py
Outdated
Show resolved
Hide resolved
Could you update the reference spec?
|
I am not sure, but it seems the test is valid from @pytest.mark.parametrize_by_fork("tx_gas_limit,error", tx_gas_limit_cap_tests)
@pytest.mark.with_all_tx_types
@pytest.mark.valid_from("Prague")
def test_transaction_gas_limit_cap(
state_test: StateTestFiller,
pre: Alloc,
fork: Fork,
tx_gas_limit: int,
error: TransactionException | None,
tx_type: int,
): |
ποΈ Description
Add missing cases for eip7825, and update the checklist items.
π Related Issues or PRs
Issue #1793
β Checklist
tox
checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx --with=tox-uv tox -e lint,typecheck,spellcheck,markdownlint
type(scope):
.mkdocs serve
locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.@ported_from
marker.