Skip to content

refactor(tests): update MSIZE and SELFBALANCE benchmark test #1771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

LouisTsai-Csie
Copy link
Collaborator

πŸ—’οΈ Description

Refactor the MSIZE and SELFBALANCE opcode based on the previous discussion in PR #1737, as the PUSH & POP pattern is not optimal. It is also part of the issue #1734.

πŸ”— Related Issues

Issue #1734

βœ… Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@LouisTsai-Csie LouisTsai-Csie self-assigned this Jun 18, 2025
@danceratopz danceratopz added the scope:tests Scope: Changes EL client test cases in `./tests` label Jun 19, 2025
@danceratopz danceratopz changed the title Refactor: update MSIZE and SELFBALANCE benchmark test refactor(tests): update MSIZE and SELFBALANCE benchmark test Jun 19, 2025
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@marioevz marioevz merged commit 558a38c into ethereum:main Jun 19, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature:zkevm scope:tests Scope: Changes EL client test cases in `./tests` type:refactor Type: Refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants