Skip to content

Fix tiny error in test_call_and_callcode_gas_calculation. #1717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

evgenyzdanovich
Copy link

@evgenyzdanovich evgenyzdanovich commented Jun 5, 2025

🗒️ Description

Fixes the tiny bug in test_call_and_callcode_gas_calculation.

  • the test is using the same hardcoded address for CALL and contains exact gas calculation.
  • as a result, the calculation was incorrect on subsequent executions (because of empty_account_cost)

The fix is easy - to generate empty address on every test execution to make sure the CALL address is indeed empty.

🔗 Related Issues

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests/tests/static have been assigned @ported_from marker.
  • Tests: A PR with removal of converted JSON/YML blockchain tests from ethereum/tests have been opened.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.
  • Tests: For PRs implementing a missed test case, update the post-mortem document to add an entry the list.

@evgenyzdanovich evgenyzdanovich force-pushed the upstream-fix-test_call_and_callcode_gas_calculation branch from dbca2f5 to 634eb75 Compare June 6, 2025 16:36
@evgenyzdanovich evgenyzdanovich requested a review from marioevz June 6, 2025 16:37
@evgenyzdanovich
Copy link
Author

@marioevz PTAL

@evgenyzdanovich
Copy link
Author

gentle ping, please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants