-
Notifications
You must be signed in to change notification settings - Fork 448
Add eth_config API definitions for EIP-7910 #678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Implements the eth_config JSON-RPC method as specified in EIP-7910 to provide comprehensive fork configuration details including current, next, and last fork configurations with their respective hashes and fork IDs. Changes: - Add eth_config method definition in src/eth/client.yaml - Add ConfigurationResponse, ConfigObject, and BlobSchedule schemas - Add bytes4 base type for CRC-32 hashes and fork IDs - Add test cases for different scenarios
Signed-off-by: Danno Ferrin <[email protected]>
Co-authored-by: Mercy Boma Naps Nkari <[email protected]>
Co-authored-by: Mercy Boma Naps Nkari <[email protected]>
- Remove configHash fields from ConfigurationResponse - Move forkId fields into ConfigObject - Invert precompiles map: name->address mapping with alphabetical sorting - Update test cases to match EIP specification format Signed-off-by: Danno Ferrin <[email protected]>
…cution-apis into eip-7910-eth_config Signed-off-by: Danno Ferrin <[email protected]>
…scheduled. Signed-off-by: Danno Ferrin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM. How were the tests generated? Would be good if we have that in rpctestgen before merging.
Tests were generated from the reference implementation and cross-compared with fork definitions. |
Implements the eth_config JSON-RPC method as specified in EIP-7910 to provide comprehensive fork configuration details including current, next, and last fork configurations with their respective hashes and fork IDs.
Changes: