Skip to content

Conversation

reedsa
Copy link
Contributor

@reedsa reedsa commented May 8, 2025

What was wrong?

Related to Issue #
Closes #

How was it fixed?

Uses click, uvicorn and jsonrpc-py to start an jsonrpc server and serves the get_accounts endpoint.

Todo:

  • Clean up commit history
  • Add or update documentation related to these changes
  • Add entry to the release notes

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@fselmo
Copy link
Contributor

fselmo commented May 8, 2025

I sort of imagined this as a separate repository to eth-tester. I'm open to this idea but it does have a bit more separation of concerns and logic if we maintained a separate repository that uses eth-tester as a dependency instead.

Curious about thoughts on that, cc: @kclowes @pacrob


edit: I started a very scrappy version of this here. But then I think we can actually write its own test suite to test the server logic on its own?

@reedsa
Copy link
Contributor Author

reedsa commented May 8, 2025

I'm cool with that too. Didnt get any push back when I mentioned it today, but this is the general idea for the server. You had started a separate packaged one too right?

This one uses jsonrpc-py, which seems like the most modern supported package. My original one uses Flask, https://github.com/reedsa/teth

@fselmo
Copy link
Contributor

fselmo commented May 8, 2025

It looks like main difference between jsonrpc-py and jsonrpcserver (what I used) is jsonrpc-py has client side also, not just server, and it supports websocket. I think the websocket support is nice to have but definitely should check temperature on maintenance. Seems like a good approach either way.

@fselmo
Copy link
Contributor

fselmo commented May 8, 2025

I think the websocket support is nice to have but definitely should check temperature on maintenance. Seems like a good approach either way.

Yeah jsonrpc-py has the latest python version support, that looks like the way to go 👍🏼


edit: Maybe another upside to maintaining as a separate repository is that jsonrpc-py only supports python 3.12 and up I think. So we can version control a bit differently since the server takes the main focus there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants