feat(eip712): enable eip712 typed data to be provided to eip712sign lib #1101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No immediate need to introduce this functionality, closing for now. |
blmalone
force-pushed
the
bm/eip712-cast
branch
from
5ed617b to
f95eeda
Compare
blmalone
force-pushed
the
bm/eip712-cast
branch
from
f95eeda to
42877c9
Compare
blmalone
changed the base branch from
graphite-base/1101
to
bm/add-trezor-support
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
blmalone
changed the title
|
I am taking the lead back on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Add support for EIP-712 structured data signing for Safe transactions, allowing signers to use tools that support typed data signing.
What changed?
EIP712_ENCODED_DATA_TO_SIGNto control whether to use EIP-712 typed data JSON for signing or just the domain and message hashes (default)encodeEIP712Jsonto generate properly formatted EIP-712 JSON for Safe transactionsgetDomainAndMessageHashFromEncodedTransactionDatatogetDomainAndMessageHashFromDataToSignto handle both formats