feat: add script to check migration result #1037
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a new script that can be used to check the result of running the interop migration. Script was originally added to OPCM but because there's no dedicated U17 OPCM.
Inphi
approved these changes
May 30, 2025
| '@openzeppelin/contracts/=lib/openzeppelin-contracts/contracts', | ||
| '@base-contracts/=lib/base-contracts/', | ||
| '@eth-optimism-bedrock/=lib/optimism/packages/contracts-bedrock/', | ||
| '@op/=lib/optimism/packages/contracts-bedrock/', |
There was a problem hiding this comment.
nit: an @eth-optimism-bedrock monorepo mapping already exists. Let's use that.
There was a problem hiding this comment.
I added it because eth-optimism-bedrock is so unnecessarily long lol
mds1
reviewed
Jun 9, 2025
| /// @notice Checks that the interop migration correctly performed basic migration steps. | ||
| /// This script is used to verify that the migration was successful and that the | ||
| /// contracts were correctly updated. | ||
| contract CheckMigrate is Script { |
There was a problem hiding this comment.
Is the intended use to inherit from this in the template task that calls opcm.migrate and then call the run method? If so, maybe we just scaffold out that task template instead and inline this directly into the validation method
There was a problem hiding this comment.
Sort of, the reason it isn't being used like that is so that we can use this script when we run devnets that don't use superchain-ops tasks
There was a problem hiding this comment.
Got it, a nit, but can we just add some natspec to make the expected usages of this script (devnet vs. superchain-ops task) self-documenting?
jcortejoso
pushed a commit
to celo-org/superchain-ops
that referenced
this pull request
Jun 11, 2025
…ethereum-optimism#1037) * Enhance CircleCI configuration with new executor and notification job - Added a default executor using Ubuntu 22.04 with medium resource class. - Introduced a new job to notify when chains are added to the registry, including logic to detect new chain configurations and report them. * Branch from test branch (ethereum-optimism#1038) * Add arena-z chain configuration - Introduced a new TOML configuration file for the arena-z chain, including details such as public RPC, sequencer RPC, explorer URL, chain ID, and various parameters related to hard forks, genesis, roles, and addresses. - This configuration supports the deployment and management of the arena-z chain within the superchain ecosystem. * Enhance CircleCI configuration to include branch check and updated file detection logic - Added a step to check if the current branch matches the specified branch before proceeding with notifications. - Updated the logic to detect newly added TOML files by comparing the most recent commit on the main branch instead of the previous branch. * Branch from test branch 2 (ethereum-optimism#1039) * Add arena-z chain configuration - Introduced a new TOML configuration file for the arena-z chain, including details such as public RPC, sequencer RPC, explorer URL, chain ID, and various parameters related to hard forks, genesis, roles, and addresses. - This configuration supports the deployment and management of the arena-z chain within the superchain ecosystem. * Enhance CircleCI configuration to include branch check and updated file detection logic - Added a step to check if the current branch matches the specified branch before proceeding with notifications. - Updated the logic to detect newly added TOML files by comparing the most recent commit on the main branch instead of the previous branch. * Enhance CircleCI configuration for Slack notifications and chain detection - Added a new parameter for Slack webhook URL to facilitate notifications. - Updated the branch check to be more generic, allowing notifications for any target branch. - Improved logic for detecting newly added chains and formatted Slack messages for better clarity. - Introduced a new job to send notifications when chains are added to the registry. * Remove arena-z chain configuration file from mainnet configs * Remove arena-z chain configuration files from mainnet configs * Fix CircleCI Slack notification command syntax by correcting the webhook URL parameter usage. * Enhance CircleCI configuration to improve Slack notifications for chain changes. Updated logic to detect added, deleted, and modified chains in the registry, and formatted messages for clarity. Adjusted notification conditions to ensure messages are sent only when changes are detected. * test * test * test * test * test * test * test * Update CircleCI configuration to add branch filters for the notify job, restricting notifications to the 'test-branch' only. * Update CircleCI configuration to change default branch from 'test-branch' to 'main' and adjust notification filters accordingly.
|
@smartcontracts is this something we will want to merge? If it's nearly over the line, I'm happy to review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new script that can be used to check the result of running the interop migration. Script was originally added to OPCM but because there's no dedicated U17 OPCM.