Update forkdiff #714
Update forkdiff #714
Conversation
Also specify the --platform.
joshklop
force-pushed
the
joshklop/forkdiff
branch
from
1c2a91e to
aae352e
Compare
![almanax-ai[bot]](https://avatars.githubusercontent.com/in/934833?s=60&v=4){kind=small}
internal/ethapi/api.go
Outdated
| if receipt.DAFootprintGasScalar != nil { | ||
| fields["daFootprintGasScalar"] = hexutil.Uint64(*receipt.DAFootprintGasScalar) | ||
| fields["daFootprintGasScalar"] = hexutil.Uint64(*receipt.OperatorFeeScalar) | ||
| // Jovian repurposes blobGasUsed for DA footprint gas used | ||
| fields["blobGasUsed"] = hexutil.Uint64(receipt.BlobGasUsed) | ||
| } |
There was a problem hiding this comment.
JSON-RPC Panic on daFootprintGasScalar Field Dereference
In internal/ethapi/api.go, the JSON-RPC response for Optimism’s Jovian fields dereferences *receipt.OperatorFeeScalar instead of *receipt.DAFootprintGasScalar, causing a nil pointer panic when OperatorFeeScalar is nil but DAFootprintGasScalar is set.
Change the dereference to use receipt.DAFootprintGasScalar. Replace *receipt.OperatorFeeScalar with *receipt.DAFootprintGasScalar to avoid nil pointer dereference.
Don't like this finding? Reply "dismiss" and it won't appear again in future scans.
There was a problem hiding this comment.
Wouldn't we need to create a docker build from our Repo? We don't have that set up yet. I think the reference here protolambda/forkdiff:latest is to the Docker registry at https://hub.docker.com/r/protolambda/forkdiff
Are we publishing the docker image yet?
make forkdiffdoesn't work locally anymore.