Replace gomodguard standalone check with golanci-lint #20772
Conversation
Based on the discussion from etcd-io#20721, and from commit 2edb086. The forbidden dependency approach in the `go.mod` files was to avoid importing etcd v1. Therefore, if we want to prohibit this dependency across all files, we can keep it centralized in the golangci-lint configuration. Given that the v2 client is also deprecated, we can add it to the forbidden dependencies. Follow up on the implementation from etcd-io#20748. Signed-off-by: Ivan Valdes <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ivanvc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@ivanvc: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted filessee 18 files with indirect coverage changes @@ Coverage Diff @@
## main #20772 +/- ##
=======================================
Coverage 69.14% 69.15%
=======================================
Files 422 422
Lines 34819 34819
=======================================
+ Hits 24077 24079 +2
+ Misses 9346 9342 -4
- Partials 1396 1398 +2 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This isn't true. We should also prevent dependency between some modules, i.e. |
|
@ahrtr, sounds good. Closing this pull request, then :) /close |
|
@ivanvc: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
3 participants
Based on the discussion from #20721, and from commit 2edb086. The forbidden dependency approach in the
go.modfiles was to avoid importing etcd v1. Therefore, if we want to prohibit this dependency across all files, we can keep it centralized in the golangci-lint configuration. Given that the v2 client is also deprecated, we can add it to the forbidden dependencies.Follow up on the implementation from #20748.
Part of #18409.
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.