idutil: document event window as 2^48 #20729
Conversation
6 byte suffix means event window is 2^48, not 2^56. Signed-off-by: Upamanyu Sharma <[email protected]>
|
Hi @upamanyus. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
... and 33 files with indirect coverage changes @@ Coverage Diff @@
## main #20729 +/- ##
==========================================
- Coverage 69.16% 69.01% -0.15%
==========================================
Files 420 417 -3
Lines 34817 34682 -135
==========================================
- Hits 24081 23936 -145
Misses 9338 9338
- Partials 1398 1408 +10 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
/retest |
| // It increases suffix to generate the next id. | ||
| // The count field may overflow to timestamp field, which is intentional. | ||
| // It helps to extend the event window to 2^56. This doesn't break that | ||
| // It helps to extend the event window to 2^48. This doesn't break that |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, upamanyus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3 participants
6 byte suffix means event window is 2^48, not 2^56.