Skip to content

etcdserver: Adding Readme file for walpb #20571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

etcdserver: Adding Readme file for walpb #20571

wants to merge 4 commits into from
+12 −0

Conversation

amentee
Copy link

@amentee amentee commented Aug 27, 2025

A Readme file is added under walpb to improve the documentation especially for new contributors.

Kumar, Sachin added 2 commits August 27, 2025 23:12
Adding Readme file for walpb
8f3668a
etcdserver: Adding README file for walpb under storage
7f827d1 
To improve the understanding of the walpb codebase. It includes short
descriptions of each file under walpb.

Signed-off-by: Sachin Kumar
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: amentee
Once this PR has been reviewed and has the lgtm label, please assign spzala for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link

Hi @amentee. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

serathius
serathius requested changes Aug 28, 2025
View reviewed changes
Copy link
Member

@serathius serathius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Low quality document generated by AI.

Even the format of quotes is wrong.

Kumar, Sachin added 2 commits August 28, 2025 17:29
etcdserver: Add readme for server/storage/wal/walpb
db34347 
To help improve the documentation of the wal system in etcd

Signed-off-by: Sachin Kumar
Merge branch 'walpb_documentation' of https://github.com/amentee/etcd …
6bd5d06 
…into walpb_documentation
@amentee
Copy link
Author

amentee commented Aug 28, 2025

Low quality document generated by AI.

Even the format of quotes is wrong.

@serathius I have trimmed down the content. Please suggest if i need to add more .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serathius serathius serathius requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
needs-ok-to-test size/S
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amentee @k8s-ci-robot @serathius