Skip to content

Conversation

Elbehery
Copy link
Member

@Elbehery Elbehery commented Aug 21, 2025

backport of #993

cc @ahrtr @ivanvc

repalces #995

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Elbehery

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ivanvc
Copy link
Member

ivanvc commented Aug 21, 2025

@Elbehery, can you update golangci-lint to use version v2.4.0? And let's see if the Windows error persists.

@Elbehery Elbehery force-pushed the 20250821_backport_linter_1.3 branch from c2c7216 to d6a782f Compare August 21, 2025 22:42
@Elbehery
Copy link
Member Author

@Elbehery, can you update golangci-lint to use version v2.4.0? And let's see if the Windows error persists.

i think we need to install v2.4.0 in a step before using it

lets see

@Elbehery
Copy link
Member Author

 golangci-lint run ./...
0 issues.

@Elbehery
Copy link
Member Author

 golangci-lint run ./...
0 issues.
golangci-lint version                                                        
golangci-lint has version 2.4.0 built with go1.25.0 from 43d03392 on 2025-08-13T23:36:29Z

@Elbehery
Copy link
Member Author

@ivanvc gh does not use v2.4.0 yet :/

@ivanvc
Copy link
Member

ivanvc commented Aug 22, 2025

Ah, 2.4.0 uses Go 1.25. We need a previous version (2.3.1). But Windows is still failing. I'll try to set up a Windows machine to replicate this locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants