Skip to content

feat(websocket): Add ws get HTTP response headers #794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

glmfe
Copy link
Collaborator

@glmfe glmfe commented Apr 2, 2025

Description

  • Expose HTTP header from the ws upgrade.

Related

@glmfe glmfe force-pushed the feat/add-get-ws-headers branch from 1d870b6 to 6a47539 Compare April 2, 2025 23:52
@glmfe glmfe self-assigned this Apr 2, 2025
@glmfe glmfe requested a review from euripedesrocha April 2, 2025 23:53
@glmfe glmfe added the websocket label Apr 2, 2025
@glmfe glmfe marked this pull request as ready for review April 30, 2025 14:23
@glmfe glmfe force-pushed the feat/add-get-ws-headers branch 2 times, most recently from 2b83ae5 to 9f1299b Compare May 6, 2025 01:34
@glmfe glmfe force-pushed the feat/add-get-ws-headers branch from 9f1299b to 3557e67 Compare May 19, 2025 08:37
@@ -134,6 +134,8 @@ typedef struct {
size_t ping_interval_sec; /*!< Websocket ping interval, defaults to 10 seconds if not set */
struct ifreq *if_name; /*!< The name of interface for data to go through. Use the default interface without setting */
esp_transport_handle_t ext_transport; /*!< External WebSocket tcp_transport handle to the client; or if null, the client will create its own transport handle. */
char *response_headers; /*!< WebSocket handshake response headers */
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
char *response_headers; /*!< WebSocket handshake response headers */
char *response_headers; /*!< WebSocket handshake response headers buffer, user is responsible for manage lifetime. */

@glmfe glmfe force-pushed the feat/add-get-ws-headers branch from 3557e67 to c74bda9 Compare June 12, 2025 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[websocket]: ability to read connection upgrade headers (IDFGH-14252)
4 participants