-
Notifications
You must be signed in to change notification settings - Fork 159
feat(websocket): Add ws get HTTP response headers #794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
glmfe
wants to merge
1
commit into
espressif:master
Choose a base branch
from
glmfe:feat/add-get-ws-headers
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+33
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1d870b6
to
6a47539
Compare
2b83ae5
to
9f1299b
Compare
components/esp_websocket_client/examples/target/main/websocket_example.c
Outdated
Show resolved
Hide resolved
9f1299b
to
3557e67
Compare
@@ -134,6 +134,8 @@ typedef struct { | |||
size_t ping_interval_sec; /*!< Websocket ping interval, defaults to 10 seconds if not set */ | |||
struct ifreq *if_name; /*!< The name of interface for data to go through. Use the default interface without setting */ | |||
esp_transport_handle_t ext_transport; /*!< External WebSocket tcp_transport handle to the client; or if null, the client will create its own transport handle. */ | |||
char *response_headers; /*!< WebSocket handshake response headers */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
char *response_headers; /*!< WebSocket handshake response headers */ | |
char *response_headers; /*!< WebSocket handshake response headers buffer, user is responsible for manage lifetime. */ |
6 tasks
3557e67
to
c74bda9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related