-
Notifications
You must be signed in to change notification settings - Fork 1
feat: default timespan #174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many of the changes in this PR are cosmetic, I have commented the important parts.
Seems to work with the basic example from the workshop. After specifying nothing at all in the user config file, you can see in the log that it will try to use
The produced files also seem to have correct timestamps:
Also internally:
Can be reviewed. If anyone wants to try inventing unit tests, please :-) |
@JanStreffing, I also added you as reviewer since it was your feature request. If you want to try this out, get the branch |
Closes #171
Still needs to be tested (for now manually), and I have no idea how to write tests for this...