Skip to content

Conversation

frazze-jobb
Copy link
Contributor

No description provided.

@frazze-jobb frazze-jobb self-assigned this Sep 23, 2025
Copy link
Contributor

github-actions bot commented Sep 23, 2025

CT Test Results

    4 files    228 suites   1h 57m 43s ⏱️
3 731 tests 3 628 ✅ 103 💤 0 ❌
4 861 runs  4 732 ✅ 129 💤 0 ❌

Results for commit eb40e71.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

Copy link
Contributor

@kikofernandez kikofernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we should add tests, similar to shell_docs_SUITE with the function docsmap.
Essentially, we want to test that we do not crash if we generate all man pages.

The main reason is that we may not crash when we test locally, but we may add some unsupported markdown that generates a new markdown AST node, and that one crashes the man page generation.

render_type(Module, D, #{}).

%% extract AST raw type specifications.
-spec extract_type_specs(atom()) -> term().
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
-spec extract_type_specs(atom()) -> term().
-spec extract_type_specs(module()) -> map().

@frazze-jobb frazze-jobb force-pushed the frazze/doc/reference_manual_to_man_page branch from 87c21c1 to a930d0c Compare September 24, 2025 10:32
@frazze-jobb frazze-jobb changed the base branch from master to maint September 24, 2025 10:32
@frazze-jobb frazze-jobb force-pushed the frazze/doc/reference_manual_to_man_page branch from a930d0c to 55121ed Compare September 24, 2025 11:06
@frazze-jobb frazze-jobb added the testing currently being tested, tag is used by OTP internal CI label Sep 25, 2025
@frazze-jobb frazze-jobb force-pushed the frazze/doc/reference_manual_to_man_page branch 5 times, most recently from 2c9753b to fb8d2ca Compare October 1, 2025 10:59
@frazze-jobb frazze-jobb force-pushed the frazze/doc/reference_manual_to_man_page branch from fb8d2ca to eb40e71 Compare October 1, 2025 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation feature team:VM Assigned to OTP team VM testing currently being tested, tag is used by OTP internal CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants