-
Notifications
You must be signed in to change notification settings - Fork 933
Getting started with railsのDSLへのリンクを日本語に #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jokojama-gou
wants to merge
10,000
commits into
ericallam:master
Choose a base branch
from
yasslab:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[8.0] upgrading_ruby_on_railsと8_0_release_notesの訳文を更新
documents.yamlを修正
typo修正です。原著の対応部分は以下。 [Active Record Validations — Ruby on Rails Guides](https://guides.rubyonrails.org/v7.2/active_record_validations.html#errors-where-and-error-object) ``` irb> person.errors.where(:name, :too_short, minimum: 3) => [ ... ] # all name errors being too short and minimum is 3 ```
…sociation ActiveRecordの関連付け has_one 誤訳を修正
development -> development:
YAMLキーdevelopment:の誤記を修正しました
…を読むのがおそらくベストです。' at the end
Remove unnecessary backquote
getting_started.mdのrich_text_areaをrich_textareaに修正
単一テスト実行時の-nオプションの修正
i18n.mdの3.7 ロケールファイルの編成を修正。 3.7 ロケールファイルの編成のNOTEを削除。 Rails 7 からデフォルトのロケール読み込みでもネストした辞書を読み込むように変更されたため、この方法は必要なし。 参考:https://blog.saeloun.com/2021/07/20/rails-7-allows-nested-locales 英文のガイドでは既にNOTEが削除されている。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DSLのwikipediaの説明へのリンクが英語だったので日本語になおしておきました😀!