Rename ertbox -> grid dimensions #12202
Open
+95
−56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12202 +/- ##
=======================================
Coverage 90.67% 90.68%
=======================================
Files 435 436 +1
Lines 29076 29093 +17
=======================================
+ Hits 26365 26382 +17
Misses 2711 2711
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
xjules
reviewed
Oct 31, 2025
| new_configs = {} | ||
| for param_config in parameters_json.values(): | ||
| if param_config["type"] == "field": | ||
| param_config["grid_dimensions"] = param_config.pop("ertbox_params") |
Contributor
There was a problem hiding this comment.
I guess this should be param_config.pop("ertbox_params", None)?
xjules
approved these changes
Oct 31, 2025
Contributor
xjules
left a comment
xjules
left a comment
There was a problem hiding this comment.
Just had a small comment in the migration but otherwise good.
CodSpeed Performance ReportMerging #12202 will not alter performanceComparing Summary
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Resolves #my_issue
Approach
Short description of the approach
(Screenshot of new behavior in GUI if applicable)
git rebase -i main --exec 'just rapid-tests')When applicable