feat!: use result instead of unwrap #12
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes dependency resolution error with rmp-serde due to them yanking all 0.15.X versions
ctrlaltf24
force-pushed
the
feat-error-type
branch
2 times, most recently
from
dad2880 to
3e0a212
Compare
Configurable line protocol by cargo feature flag Added tests to cover the new server implementation No breaking changes to public API
- emit/emit_json functions switch from taking ownership and returning Emitter to taking mutable ref returning a result of an empty tuple
ctrlaltf24
force-pushed
the
feat-error-type
branch
from
3e0a212 to
c5053b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use result type to prevent the entire application from failing when there is an error connecting to redis while using this library.
built on: #11
Breaking changes: