Skip to content

Conversation

exacs
Copy link
Contributor

@exacs exacs commented Oct 7, 2025

This PR fixes the sample sites after the change in #124.

  • The hello-world site shows a 404 if content is not found
  • In fx-variation, it shows the original if a variation is not found; if that original is also not found, shows a 404

@exacs exacs requested review from TRomesh and Copilot October 7, 2025 08:40
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances error handling in sample sites to properly manage cases where content is not found, addressing issues introduced by changes in PR #124.

  • Adds 404 handling for missing content in both sample sites
  • Implements fallback logic in fx-integration to show original content when variations are not found
  • Replaces error-based fallback with explicit empty content checks

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
samples/hello-world/src/app/[...slug]/page.tsx Adds 404 handling when no content is found for the requested path
samples/fx-integration/src/app/en/[...slug]/page.tsx Implements fallback logic and 404 handling with a reusable helper function

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@exacs exacs requested a review from JohanPetersson October 9, 2025 06:30
@exacs exacs merged commit d2196b8 into main Oct 9, 2025
2 checks passed
@exacs exacs deleted the bugfix/CMS-45847-handle-empty branch October 9, 2025 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants