Skip to content

Growth estimators #1076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

adrian-lison
Copy link

Description

This PR closes #768.

The PR adds a new option to calculate the growth rate in estimate_infections() and simulate_infections() that is based on an estimator by Parag et al. 2022.

Initial submission checklist

  • My PR is based on a package issue and I have explicitly linked it.
  • I have tested my changes locally (using devtools::test() and devtools::check()).
  • I have added or updated unit tests where necessary.
  • I have updated the documentation if required and rebuilt docs if yes (using devtools::document()).
  • I have followed the established coding standards (and checked using lintr::lint_package()).
  • I have added a news item linked to this PR.

After the initial Pull Request

  • I have reviewed Checks for this PR and addressed any issues as far as I am able.

@adrian-lison
Copy link
Author

@seabbs @sbfnk

Just opened a draft PR while working on this. I have drafted the basic stan code, but couldn't test it locally yet because of issues with my rstan installation ^^

I have for now added an argument growth_method to the rt_opts(), because I didn't find it justified to create a completely new opts type. There are a couple of open questions to discuss, in particular how much of a problem it is that with the alternaitve approach the most recent growth rates are undefined due to the shift applied.

Will get back with more details soonish.

Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if f15d0d6 is merged into main:

  • ✔️default: 22.8s -> 23.3s [-7.84%, +12.97%]
  • ✔️no_delays: 23.1s -> 29.2s [-26.06%, +78.93%]
  • ✔️random_walk: 8.83s -> 9.37s [-2.79%, +14.91%]
  • ✔️stationary: 15.8s -> 11.2s [-94.64%, +36.65%]
  • ✔️uncertain: 35.7s -> 34.1s [-14.02%, +5.17%]
    Further explanation regarding interpretation and methodology can be found in the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Growth rate estimators
1 participant