Skip to content

ZeroExpr must check for a disjonction for multiplication #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 24, 2025
Merged

ZeroExpr must check for a disjonction for multiplication #132

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8ee300b
zeroExpr must check for a disjonction for multiplication
samuelchassot Apr 17, 2025
6c5a4a7
mirror was not mirroring the mult
samuelchassot Apr 17, 2025
16ee7b6
Merge branch 'main' into sam/constfold
samuelchassot Oct 24, 2025
34d48a4
Merge branch 'main' into sam/constfold
samuelchassot Oct 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions tutorials/const-fold/ConstFold.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,17 @@ object ConstFold:
case Var(_) => false
case Add(e1, e2) => zeroExpr(e1) && zeroExpr(e2)
case Minus(e1, e2) => zeroExpr(e1) && zeroExpr(e2)
case Mul(e1, e2) => zeroExpr(e1) && zeroExpr(e2)
case Mul(e1, e2) => zeroExpr(e1) || zeroExpr(e2)

def lemma(ctx: Env, @induct e: Expr): Unit = {
def lemma(ctx: Env, e: Expr): Unit = {
require(zeroExpr(e))
()
e match
case Number(_) => ()
case Var(_) => ()
case Add(e1, e2) => lemma(ctx, e1); lemma(ctx, e2)
case Minus(e1, e2) => lemma(ctx, e1); lemma(ctx, e2)
case Mul(e1, e2) => if (zeroExpr(e1)) then lemma(ctx, e1) else lemma(ctx, e2)

}.ensuring(_ => evaluate(ctx, e) == 0)

def mirror(e: Expr)(anyCtx: Env = zeroEnv): Expr = {
Expand All @@ -39,7 +45,7 @@ object ConstFold:
case Var(name) => e
case Add(e1, e2) => Add(mirror(e2)(anyCtx), mirror(e1)(anyCtx))
case Minus(e1, e2) => Minus(mirror(e1)(anyCtx), mirror(e2)(anyCtx))
case Mul(e1, e2) => Mul(mirror(e1)(anyCtx), mirror(e2)(anyCtx))
case Mul(e1, e2) => Mul(mirror(e2)(anyCtx), mirror(e1)(anyCtx))
}.ensuring(evaluate(anyCtx, _) == evaluate(anyCtx,e))

abstract class SoundSimplifier:
Expand Down