Gui improvement 07 07 2025 #4124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamyshova
requested changes
Oct 27, 2025
Comment on lines
18
to
23
| import static com.epam.pipeline.autotests.ao.Primitive.INSTANCE_TYPE; | ||
| import com.epam.pipeline.autotests.ao.Template; | ||
| import com.epam.pipeline.autotests.mixins.Navigation; | ||
| import com.epam.pipeline.autotests.utils.C; | ||
| import static com.epam.pipeline.autotests.utils.C.DEFAULT_INSTANCE; | ||
| import static com.epam.pipeline.autotests.utils.C.DEFAULT_INSTANCE_PRICE_TYPE; |
There was a problem hiding this comment.
General comment - please group imports logically (e.g. static with static, standard with standard) to improve readability and follow clean code conventions
| private static final String CONFIG_JSON = "config.json"; | ||
| private static final String STORAGE_RULES_FOLDER = "storage_rules_folder"; | ||
| private static final String FILE_TO_STORE_NAME = "storage_rules_test.test"; | ||
| private static final String LAUNCH_SCRIPT = "/fileKeeper.sh"; |
There was a problem hiding this comment.
Do we need to update the standard indent settings here?
| import com.epam.pipeline.autotests.ao.PipelineCodeTabAO; | ||
| import com.epam.pipeline.autotests.ao.Template; | ||
| import com.epam.pipeline.autotests.utils.C; | ||
| import static com.epam.pipeline.autotests.utils.C.DEFAULT_INSTANCE_PRICE_TYPE; |
| package com.epam.pipeline.autotests; | ||
|
|
||
| import com.epam.pipeline.autotests.ao.NotificationAO; | ||
| import static com.epam.pipeline.autotests.ao.Primitive.ADD_SCHEDULE; |
| "and contains(., 'Root entity type')]"); | ||
| } | ||
|
|
||
| public static By rootEntityTypeValue() { |
kamyshova
approved these changes
Oct 27, 2025
# Conflicts: # e2e/gui/src/test/java/com/epam/pipeline/autotests/RestrictionsOnInstancePriceTypeTest.java # e2e/gui/src/test/java/com/epam/pipeline/autotests/ao/Primitive.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides e2e-tests updates corresponding last UI update: