-
Notifications
You must be signed in to change notification settings - Fork 42
chore: Update Annotation to Python 3.12 #1034
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vukosavljevicNatalija
wants to merge
32
commits into
epam:main
Choose a base branch
from
vukosavljevicNatalija:chore/annotation-upgrade-python#816
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
chore: Update Annotation to Python 3.12 #1034
vukosavljevicNatalija
wants to merge
32
commits into
epam:main
from
vukosavljevicNatalija:chore/annotation-upgrade-python#816
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR upgrades the Annotation service to Python 3.12 and adapts the code to work with Pydantic v2 along with updating dependencies and tooling. Key changes include:
- Replacing Pydantic v1 methods (.dict()) with their v2 equivalents (.model_dump()), and updating validators to use model_validator.
- Updating SQLAlchemy bulk insert methods, dependency header examples, and various schema field definitions to use the new “examples” syntax.
- Bumping dependency versions in the Dockerfile, pre-commit hooks, and GitHub Actions workflow.
Reviewed Changes
Copilot reviewed 36 out of 36 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
annotation/annotation/tasks/services.py | Converted schema dumping methods and replaced bulk insert mappings with the ORM insert feature. |
annotation/annotation/resources.py, schemas, categories, jobs, annotations | Updated header and field example parameters and validators to the new Pydantic v2 syntax. |
annotation/Dockerfile, .pre-commit-config.yaml, .github/workflows/annotation.yml | Upgraded base images, dependency versions, and adjusted install commands for Python 3.12. |
cakeinsauce
requested changes
Jun 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task
Action
pyproject.toml
, along with the upgrade of some dependencies as a result of this change.Pydantic
to v2. Thebump-pydantic
tool was run to assist the conversion from v1 to v2. However, some changes needed to be performed manually due to issues like this one: pydantic/bump-pydantic#134. Afterward, the code that was usingPydantic
schemas was adapted toPydantic v2
.Additionally, some issues occurred with numeric constraints when updating to the
Pydantic
version, and these issues were resolved by using Annotated pydantic-constraint.root_path
parameter. More information can be found in this closed PR. Additionally, there were issues withTestClient
that can be solved by using thebump-testclient
package.flake8
,black
, andisort
were updated to match the project’spyproject.toml
. Also,moto
was updated because the previous version had issues with SSL.Dockerfile
, pre-commit hooks, and GitHub Actions file were updated to adapt to Python 3.12.Furthermore,
isort
command in Annotation .pre-commit hook was updated to use Annotation folder as a source.Pydantic
. More information about the expecteddatetime.datetime
field format can be found pydatic-datetime.SQLAlchemy
bulk_insert_mappings
method was replaced with the bulk ORM insert feature insert due to issues issue in earlier versions ofSQLAlchemy 2.*
. Additionally, this method is deprecated and will be removed in future versions.