feat: add DialDateCellRenderer for formatted date display in grid #143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| suppressSizeToFit: true, | ||
| cellRenderer: DialDateCellRenderer, | ||
| cellRendererParams: { | ||
| locale: 'en-US', |
There was a problem hiding this comment.
please, explain - let discuss
| export { DialFileName } from './components/FileName/FileName'; | ||
| export { DialFolderName } from './components/FolderName/FolderName'; | ||
|
|
||
| //Grid |
There was a problem hiding this comment.
please, add space
| ); | ||
| }; | ||
|
|
||
| function convertToDate(input?: AgGridValue | null): Date | null { |
There was a problem hiding this comment.
please, move to utils and add tests
| if (typeof input === 'string') { | ||
| const trimmed = input.trim(); | ||
|
|
||
| if (/^-?\d+$/.test(trimmed)) { |
There was a problem hiding this comment.
please, explain
| const content = useMemo(() => { | ||
| if (!date) return emptyPlaceholder; | ||
|
|
||
| const formatted = new Intl.DateTimeFormat(locale, { |
There was a problem hiding this comment.
not for admin - let's discuss
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
<SHORT_DESCRIPTION>
Issues:
UI changes
Checklist:
fix:,feat:,feature:,chore:,hotfix:ore2e:. If contains breaking changes then the pull request name must start withfix!:,feat!:,feature!:,chore!:,hotfix!:ore2e!:.(Issue #<TICKET_ID>)(comma-separated list of issues)New Component Checklist:
e.g.
import { Button } from '@/components/Button/Buttoninstead ofimport { Button } from '../../Button/Button