Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ext_proc: Add processing_effect to ExtProcLoggingInfo
Commit Message: Add a bit to track mutations within ext_proc filter state ExtProcLoggingInfo.
Additional Description: This bit will track if a mutation occurred, if continue_and_replace was used or if an immediate response was sent. This addition will help with observability by gaining visibility into what ext_proc mutations occur.
Memory Implication: Since the defined enum has 4 values I chose use
enum class: char
to store the values as chars rather than ints. Therefore each enum variable will only be 1 byte of memory.Risk Level: Low
Testing: Added multiple integration tests to ext_proc_integration_test.cc to validate this bit is set correctly in all 4 scenarios: no mutations, content modified, continue and replace and immediate response
Release Notes: Added new logging bit processing_effect to ExtProcLoggingInfo Filter State to track mutation events per GRPC call. Proccessing_event can be either None, ContentModified, ContinueAndReplace or ImmediateResponse. The default is None except processing mode FULL_DUPLEX_STREAMED whose defualt is Content Modified.
Docs Changes: N/A
Platform Specific Features: N/A
/assign @yanjunxiang-google