router: Connection metadata subset match #41277
Open
+344
−91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ben Plotnick <[email protected]>
Signed-off-by: Ben Plotnick <[email protected]>
Signed-off-by: Ben Plotnick <[email protected]>
bplotnick
changed the title
Signed-off-by: Ben Plotnick <[email protected]>
KBaichoo
previously approved these changes
Oct 1, 2025
|
pending CI fixes: Seems like the test failures might be legit: /wait |
Signed-off-by: Ben Plotnick <[email protected]>
|
/retest |
…-match Signed-off-by: Ben Plotnick <[email protected]>
Signed-off-by: Ben Plotnick <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: Allow subsetlb to match on connection metadata in addition to the existing route and request metadata
Additional Description: Currently, the subsetlb only looks at request and route metadata. In some cases, we might want to use connection-level dynamic metadata as well. This adds support for that.
Risk Level: Low
Testing: Unit tests
Docs Changes:
Release Notes: Router now takes into account connection-level metadata under the
envoy.lbnamespace when computing subset load balancing matches.Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]