http2: fix a bug where memory will leak if stream is reset before send headers #41260
+23
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: WangBaiping <[email protected]>
Signed-off-by: WangBaiping <[email protected]>
|
Although the code is very simple, I think this deserves a careful review of senior maintainers because this change the lifetime of the stream to avoid memory leak. |
Signed-off-by: WangBaiping <[email protected]>
|
/retest |
|
I don't know enough about the http codecs to effectively review this; removing myself. |
|
I will be OOM for this week. Will try to add the test once I back :) |
|
/wait |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: http2: fix a bug where memory will leak if stream is reset before send headers
Additional Description:
To close #40253.
Risk Level: mid. core http2 code change.
Testing: unit.
Docs Changes: n/a.
Release Notes: added.