- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 7k
Fix Windows test failures and remove debug prints for DRF #9808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix Windows test failures and remove debug prints for DRF #9808
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes cross-platform test failures on Windows with Python 3.13 and removes debug print statements from the test suite. The main changes ensure that path-based tests handle Windows backslashes correctly and that regex patterns are flexible enough to accommodate platform-specific variations in object representations.
- Fixed Windows path escaping issues in TestRegularFieldMappings.test_regular_fields
- Relaxed regex patterns to handle cross-platform differences in object string representations
- Removed 7 debug print() statements from OpenAPI schema tests
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description | 
|---|---|
| tests/test_model_serializer.py | Updated regex patterns to handle Windows paths and cross-platform object representations; added re.DOTALLflag for multi-line matching | 
| tests/schemas/test_openapi.py | Removed debug print() statements that were cluttering test output | 
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Windows requires manual backslash replacement for repr() matching:
- repr() displays C:\Users as 'C:\Users' (double backslashes)
- Regex needs \\ to match \ (four backslashes in pattern)
- re.escape() only produces \ (matches single backslash)
Test evidence on Windows:
  re.escape(path) in repr(path): None (fails)
  path.replace('\', r'\\') in repr(path): Match (works)
Solution:
- Windows: Manual replacement for repr() double-escaping
- Unix: re.escape() for special character handling
Addresses @auvipy's review with detailed testing and explanation.
    | I just wanted to share my perspective here: 
 windows user can use wsl | 
| 
 Thanks @p-r-a-v-i-n for the feedback! I completely understand your perspective — I just wanted to share a bit more context on why I approached it this way: On complexity: On Windows support: 
 Ensuring tests run natively on Windows helps all of these contributors. On maintenance: On philosophy: That said, if the maintainers prefer to keep DRF tests Linux-only, I completely understand and can withdraw the PR — no hard feelings. Just wanted to help make contributing easier for Windows developers! Background: I also want to share that I primarily work on Windows for personal/work reasons. While WSL is available, my current setup is Windows-native. When I tried to set up the DRF repo and run the test suite to verify my local environment, I encountered these platform-specific failures. Note: This test was already present in the codebase — I’ve only modified it slightly to make it multi-platform compatible. | 
What this PR does
Background / Why
While setting up DRF on Windows 11 with Python 3.13,
I noticed:
Some serializer tests failed due to unescaped backslashes in Windows paths
Regex matching in TestRegularFieldMappings was too strict for platform-specific variations
Debug print() statements cluttered test output and were unnecessary
These issues prevent Windows developers from running the full test suite successfully and affect cross-platform reliability.
How I fixed it
Impact
Discussion / Reference
Original discussion: DRF Discussion #9807
Notes
Verified screenshots
window:
wsl: