chore: correctly validate unique constraints with distinct condition fields #9744
+98
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ogether validator
auvipy
reviewed
Jul 21, 2025
| @@ -1435,12 +1435,22 @@ def get_unique_together_constraints(self, model): | |||
| for unique_together in parent_class._meta.unique_together: | |||
| yield unique_together, model._default_manager, [], None | |||
| for constraint in parent_class._meta.constraints: | |||
| if isinstance(constraint, models.UniqueConstraint) and len(constraint.fields) > 1: | |||
There was a problem hiding this comment.
do this need to be removed?
There was a problem hiding this comment.
We're now including the condition fields as part of the applicable fields that contribute to this count below. If we kept this here the condition fields would not be considered, which we need for this fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves: #9707.