More flexible src/rec definitions #179
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prisae
force-pushed
the
input-shapes
branch
2 times, most recently
from
e2922fc to
c1a2fcc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#185 introduced more flexible definitions for the
x/y-coordinates of dipoles (dipole,dipole_k,analytical).This PR implements more flexibility for the definition of sources and receivers in bipoles (
bipole,loop). Namely, that any ofx0, x1, y0, y1, z0, z1/x, y, z, azm, dipcan be provided of size (N,) or (1,).Addressing #181