Add debugging prints to test_stat_chmod #25025
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Debugged this on my local CI, not needed anymore. |
juj
added a commit
to emscripten-core/emsdk
that referenced
this pull request
Aug 27, 2025
Previously, if one used e.g. command ``` emsdk install --override-repository emscripten-main-64bit@https://github.com/juj/emscripten/tree/my_own_emscripten_branch emscripten-main-64bit ``` then the overridden installation would create a git clone from `juj/emscripten`, and that clone would be located under the default remote name `origin`. This would prevent being able to switch between overrides on subsequent `emsdk install` commands. I.e. it would then not be possible to later do a default ``` emsdk install emscripten-main-64bit ``` command without an override, since the remote name `origin` would point to `juj/emscripten` instead of `emscripten-core/emscripten`. This PR changes the naming scheme of `git clone`s when `--override-repository` is used, to name the clones with remote names from the override, so in the above case, the clone would appear under remote name `juj` and not `origin`. This enables flipping between multiple `emsdk install` commands in the same checkout, without needing to nuke the installed directory in between. This enables me to run experiments like github.com/emscripten-core/emscripten/pull/25025 locally on my CI, without needing to merge them upstream to become available.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I locally ran
test/runner --repeat 100 --failfast *.test_stat_chmod*on my Linux workstation, and could not coax out a single failure.Nevertheless, on that very same workstation, the test maybe about 10%-20% of the time when run as part of the CI.
So add debug prints to help suggest if the issue is about close-but-not-quite timestamps, or something else.
Related to #24905.