-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Modify musl errno messages to match llvm-libc #24983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
reviewed
Aug 20, 2025
system/lib/llvm-libc/src/__support/StringUtil/platform_errors.h
Outdated
Show resolved
Hide resolved
a7c7e2b
to
413e0f4
Compare
10b9ac0
to
2c3d78c
Compare
sbc100
approved these changes
Aug 24, 2025
Can you update the PR description to remove |
Can you also update the "Owner died" message. See #25008 |
There's also this difference:
|
Done. |
sbc100
approved these changes
Aug 26, 2025
Given that llvm-libc suite now passes, I added it to run as part of my local test lab CI suite at http://clbri.com:8010/#/builders |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.