Update ruby and ffi gem to support M1 macs #121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Updating ffi is no problem, but bumping the Ruby version requires updating the server, so I'm not going to merge this just yet. Can you work off of a branch? |
Contributor
Author
|
Yes I am super-happy to work off a branch (or even just using rvm locally), I was just opening this PR to keep track of changes in case anyone else wanted them 👍 Would you like me to commit the ffi changes in a different branch? would this be helpful or will I just keep them to myself for now? |
Member
|
Let's keep them together for now. I'm not sure if updating |
mansona
force-pushed
the
support-m1-mac
branch
from
f23e747 to
26fe4f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a bit of googling there was some suggestion that I needed to update ruby to at least 2.6.8 (or 2.7.x, there was some conflicting info) and the ffi gem to "a version that supported M1 macs" so I updated it to the latest 👍
I don't really know the ramifications of this because I'm not a Ruby guy, but I ran
bundle exec rake testlocally and it seemed to work 🤷