Skip to content

Remove unrequired generic from run_time_sampler #4782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+2 −1
Open

Remove unrequired generic from run_time_sampler #4782

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d71ccd7
Remove unrequired generic from run_time_sampler
Hellymaw Oct 24, 2025
c41d328
Add changelog entry
Hellymaw Oct 24, 2025
89247f7
Merge branch 'main' into patch-1
Hellymaw Oct 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions embassy-nrf/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- changed: do not panic on BufferedUarte overrun
- added: allow direct access to the input pin of `gpiote::InputChannel`
- bugfix: use DETECTMODE_SEC in GPIOTE in secure mode
- changed: removed unused generic from `Saadc::run_timer_sample`

## 0.8.0 - 2025-09-30

Expand Down
2 changes: 1 addition & 1 deletion embassy-nrf/src/saadc.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -443,7 +443,7 @@ impl<'d> Saadc<'d, 1> {
/// that the size of this buffer can be less than the original buffer's size.
/// A command is return from the closure that indicates whether the sampling
/// should continue or stop.
pub async fn run_timer_sampler<I, S, const N0: usize>(
pub async fn run_timer_sampler<S, const N0: usize>(
&mut self,
bufs: &mut [[[i16; 1]; N0]; 2],
sample_rate_divisor: u16,
Expand Down