A bunch of fixes #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…are with google auth
…initial return value was not parsed
|
Thanks for sending this in Martin. I have been meaning to fix some of these issues (jwt v3, concurrency, ...) and haven't got around that. I am glad somebody did :). I will review all the changes and merge them. Will let you know if I have any question on gitter, stay tuned. Thanks for using and contributing back. |
|
I will be merging/tackling these changes piece by piece. I have just handled the changes needed for jwt 3.0. |
openid/signingkeyprovider.go
Outdated
| @@ -70,8 +76,7 @@ func (s *signingKeyProvider) getSigningKey(issuer string, kid string) (interface | |||
| } | |||
|
|
|||
| func findKey(km map[string][]signingKey, issuer string, kid string) []byte { | |||
| lock.RLock() | |||
There was a problem hiding this comment.
@lonelycode I am merging pieces of this PR to the master branch...Do you recall what was wrong with having the lock.RLock() inside of the findKey func? I see you changed the approach but I dont see the issue with your previous one.
|
Hmmm, for the life of me I cannot remember :-/ |
This makes diagnosing the problem (on tyk) much easier, since the error returned here ends up in the logs.
This brings in the change from one of the use cases we have for this library. It's been a part of the vendored version only, which obviously breaks easily and can't be tracked normally, so should be a part of the repo. Also updates usage of go-jose as it changed Json* type names to all uppercase some time ago, which breaks things unless the application pins a specific version (which needs to be deduced).
Exposes TokenValidator func and JWTTokenValidator interface, updates
Make token getter function customizable
feat: propogate actual jwks error
add support for dsa and ecdsa keys
Change bumps version golang-jwt librarie and fixes changes in jwt.Parse function definition, which is golang-jwt library braking change.
Change bumps version of golang-jwt/v4 to v4.4.2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't expect this to be merged, but some of these commits might help... we've been using this a lot and discovered that it is not concurrency safe and so have added some mutexes.
Also worth noting is there is a bug which caused the JWK to always be refreshed which is now fixed.
Because type assertions are used quite liberally there's a lot of places panics can occur when a map read doesn't turn out as expected - have tried to address the one that's been causing the most headaches.
Oh, and this uses JWT-go v3
:-)