-
Notifications
You must be signed in to change notification settings - Fork 18
Add global minor modes for EXWM's features #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* exwm-core.el (exwm--define-global-minor-mode): Macro for arranging EXWM mode hooks, logging. * exwm-background.el: Add global mode definition (exwm-background-enable): mark obsolete * exwm-randr.el (randr): as above (exwm-randr-enable): as above * exwm-systemtray.el (systemtray): as above (exwm-systemtray-mode): as above * exwm-xim.el (xim): as above (exwm-xim-enable): as above * exwm-xsettings.el (xsettings): as above (exwm-xsettings-enable): as above Condition defcustom setters on global mode presence.
This applies the feedback from #43. Unfortunately, the autoloads aren't quite correct for minor modes and I'm not sure if there's a way to fix them while still using macros. Specifically, the autoloads should look something like: (defvar exwm-systemtray-mode nil "....")
(custom-autoload exwm-systemtray-mode "exwm-systemtray" nil)
(autoload 'exwm-systemtray-mode "exwm-systemtray" "..." t) Importantly, we're missing the |
Maybe a better alternative would be to not use a macro for the whole mode, but only for the body |
Anything after the autoload-cookie will be copied verbatim to the generated autoloads file. ;;;###autoload(defvar exwm-xsettings-mode nil)
;;;###autoload(custom-autoload 'exwm-xsettings-mode "exwm-xsettings" nil)
;;;###autoload(autoload 'exwm-xsettings-mode "exwm-xsettings"
;;;###autoload"Global minor mode for toggling EXWM Xsettings support.")
(exwm--define-global-minor-mode xsettings
"Global minor mode for toggling EXWM Xsettings support.") |
@Stebalien see #46 |
Merged #46 |
(fixup commits before merging)